Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Add info to package.json #418

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Add info to package.json #418

merged 1 commit into from
Aug 19, 2015

Conversation

noskov
Copy link
Contributor

@noskov noskov commented Aug 19, 2015

No description provided.

olefredrik added a commit that referenced this pull request Aug 19, 2015
Add info to package.json
@olefredrik olefredrik merged commit 1bc3344 into olefredrik:master Aug 19, 2015
@Aetles
Copy link
Contributor

Aetles commented Aug 19, 2015

This also contained changes in css/foundation.css, css/foundation.css.map and js/foundation.js, was that deliberate?

@noskov
Copy link
Contributor Author

noskov commented Aug 19, 2015

Hi @Aetles ,
Nope, it was just "grunt build". I have made no changes to styles/scripts.

@olefredrik
Copy link
Owner

@Aetles : css/foundation.css, css/foundaiton.css.map and js/foundation.js will automatically be changed whenever you do a grunt build. Would it be a good idea to add these files in .gitignore? Does it make any sense to track changes in these files? What do you think?

@noskov
Copy link
Contributor Author

noskov commented Aug 19, 2015

@olefredrik ,
I think so, it's a good idea. In any case I don't see any reason to track all these changes in the main repo.
+1 to ignore them.

@Aetles
Copy link
Contributor

Aetles commented Aug 19, 2015

Ah, that's what I thought, all changes seemed unimportant, as if they came from a slightly different grunt build (like #fff to #FFFFFF). There where some path changes in the .map file, but those seemed to be correct. Just wanted to make sure, diffs of minified files are hard to read :)

Anyway, about adding them to .gitignore: that makes sense, since they are part of the build process. It would make pull requests less likely to include extra files. I can't think of a good reason to track them right now. If someone need them in their clone of FoundationPress they can always delete the lines from .gitignore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants